Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve tab nav responsivity #242

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat: improve tab nav responsivity #242

merged 1 commit into from
Nov 8, 2023

Conversation

MikeLebeau
Copy link

  • Add responsive behavior: column on small screen (>640px) + carriage return on bigger screen
  • Refacto CSS to use tailwind

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@MikeLebeau MikeLebeau requested a review from mattgoud November 8, 2023 15:43
@mattgoud mattgoud merged commit c3af2d4 into main Nov 8, 2023
2 checks passed
@mattgoud mattgoud deleted the improve_tab-nav branch November 8, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgoud mattgoud mattgoud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeLebeau @mattgoud