Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Monorepo Architecture #244

Merged
merged 30 commits into from
Jan 24, 2024
Merged

New Monorepo Architecture #244

merged 30 commits into from
Jan 24, 2024

Conversation

aAmorim27
Copy link
Contributor

@aAmorim27 aAmorim27 commented Nov 10, 2023 •
edited
Loading

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

⚠️ This PR may have introduced breaking changes given that some things like props & Enums have been renamed , the monorepository architecture has been reworked and the package build & release system too

Here are some of the changes introduced by this PR:

  • Replace current build system by Vite
  • Rename all packages to adopt the prestashopcorp prefix
  • Each publishable package must have his vite config file
  • Create a common build utils for all the packages
  • Remove circular dependencies between packages
  • Create a package for resolver
  • Drop buildProps method
  • Drop withInstall & makeInstall
  • Use PrestashopCorp eslint config
  • Simplify release process to release multiple packages at the same time
  • Add WebComponent support
  • Update dependencies to latest
  • Remove unused dependencies
  • Remove lodash

🧰 Architecture & build system changes

Old monorepo:
puik-old-monorepo

New monorepo:
puik-new-monorepo

Old build system:
TODO

New build system:
new-build-system

Puik Packages dependency graph:
pkg-dependecy-graph

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@aAmorim27 aAmorim27 added the WIP Status: Work In Progress label Nov 15, 2023
@aAmorim27
feat: create build utils, build from workspace root & parallelize build
7762388
@aAmorim27
fix: improve treeshake for bundlers
5fd5386
@aAmorim27
feat: started removing unused dependencies, removed scripts folder, u…
3dfb805 
…pdated release workflow

feat: improved tsconfig file, tsc check for each packages
@aAmorim27
fix: unit tests
e44d796
@aAmorim27
feat: use prestashop eslint config
18a8d30
@aAmorim27
feat: remove prettier, use comma & single quotes
c8143ef
@aAmorim27
refactor(tests): import component in tests using the package name, us…
c0cfbd4 
…e correct props types for tests
@aAmorim27
fix: global package usage & resolver imports, playground fixes
e7ded8d
@aAmorim27
fix: update hygen templates to fix with new changes
756eb2d
@aAmorim27
refactor(tests): use exported props instead of extracting them from t…
e86f5dc 
…he vue file with a utils
@aAmorim27
Merge remote-tracking branch 'origin' into feat/new-monorepo
1a04bd4
@aAmorim27
docs: updated documentation
c174c66
@aAmorim27 aAmorim27 removed the WIP Status: Work In Progress label Nov 24, 2023
@aAmorim27 aAmorim27 marked this pull request as ready for review November 24, 2023 16:30
@aAmorim27 aAmorim27 changed the title WIP - New Monorepo Architecture New Monorepo Architecture Nov 27, 2023
cnavarro-prestashop
cnavarro-prestashop requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@cnavarro-prestashop cnavarro-prestashop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Maybe we need to write a documentation to upgrade from PUIK v1 to v2 with the list of breaking changes.

.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
.github/workflows/cd-publish-package.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.prettierignore Show resolved Hide resolved
packages/components/input/src/controls/controls.ts Outdated Show resolved Hide resolved
packages/components/input/src/input.ts Outdated Show resolved Hide resolved
packages/components/input/src/input.ts Outdated Show resolved Hide resolved
packages/components/label/test/label.spec.ts Outdated Show resolved Hide resolved
packages/components/link/src/link.ts Outdated Show resolved Hide resolved
mattgoud
mattgoud previously requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@mattgoud mattgoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congrats for this big job, a great v2 coming up 👍

@cnavarro-prestashop cnavarro-prestashop changed the base branch from main to feat/2.0.0-beta January 24, 2024 09:08
@cnavarro-prestashop cnavarro-prestashop dismissed mattgoud’s stale review January 24, 2024 09:13

Ok after discussion with you

@mattgoud mattgoud merged commit 8bb6dbe into feat/2.0.0-beta Jan 24, 2024
1 check passed
@mattgoud mattgoud deleted the feat/new-monorepo branch January 24, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnavarro-prestashop cnavarro-prestashop cnavarro-prestashop approved these changes

@mattgoud mattgoud mattgoud left review comments

@MikeLebeau MikeLebeau Awaiting requested review from MikeLebeau

Assignees

@aAmorim27 aAmorim27

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aAmorim27 @mattgoud @cnavarro-prestashop