Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/sortable table #259

Merged
merged 17 commits into from
Dec 5, 2023
Merged

Feat/sortable table #259

merged 17 commits into from
Dec 5, 2023

Conversation

mattgoud
Copy link
Collaborator

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

https://forge.prestashop.com/browse/VAL-374
related issue #248

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud linked an issue Nov 27, 2023 that may be closed by this pull request
[Table] sorting feature #248
Closed
@mattgoud mattgoud marked this pull request as ready for review November 29, 2023 22:29
@mattgoud mattgoud added the Feature Type: New Feature label Nov 29, 2023
@mattgoud mattgoud linked an issue Dec 4, 2023 that may be closed by this pull request
[BUG] Table component align content #239
Closed
@mattgoud mattgoud requested review from cnavarro-prestashop and removed request for cnavarro-prestashop December 4, 2023 13:56
@mattgoud mattgoud requested review from cnavarro-prestashop and removed request for cnavarro-prestashop December 4, 2023 14:01
@mattgoud mattgoud merged commit ef6f90b into main Dec 5, 2023
2 checks passed
@mattgoud mattgoud deleted the feat/sortable-table branch December 5, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnavarro-prestashop cnavarro-prestashop cnavarro-prestashop approved these changes

Assignees
No one assigned
Labels
Feature Type: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Table] sorting feature [BUG] Table component align content
2 participants
@mattgoud @cnavarro-prestashop