Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to fix first parent who don't have a data-test by default #260

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

guillaume60240
Copy link
Collaborator

💥 Warning

breaking changes on data-test attributes

Some components present a problem when they have already been used with a data-test attribute before version 1.8. To correct this, I added a data-test (without adding a prefix) to the first parent of the components that I spotted

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@guillaume60240
Copy link
Collaborator Author

Attention, il y aura un breaking change pour la progress bar afin de respecter la demande d'avoir un data-test sans préfixe sur le premier parent (seul fichier de test modifié)

Copy link

@kktos kktos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add a test about this feature.
As a rule of thumb, when a bug is discovered, you add a test in your unit test to check it, you do the fix and you see if the test is passing.
This will help against regressions ;)

@mattgoud
Copy link
Collaborator

I think you should add a test about this feature. As a rule of thumb, when a bug is discovered, you add a test in your unit test to check it, you do the fix and you see if the test is passing. This will help against regressions ;)

ok @kktos, tests relating to the new data-tests created

@mattgoud mattgoud requested a review from kktos November 28, 2023 10:41
@mattgoud mattgoud merged commit bb72e08 into main Nov 28, 2023
2 checks passed
@mattgoud mattgoud deleted the fix-data-test branch November 28, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants