Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start add notification bar #279

Merged
merged 4 commits into from
Feb 15, 2024
Merged

feat: start add notification bar #279

merged 4 commits into from
Feb 15, 2024

Conversation

ga-devfront
Copy link
Contributor

@ga-devfront ga-devfront commented Dec 15, 2023

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Is a new component needed for some modules on BO.

The PR is not finished, the component needs tests and storybook, but I need your opinion before continuing because I am not sure that my component / style is up to standard with the latest direction puik is taking. Can you help me on this point?

Figma : https://www.figma.com/file/YxI7gWKwOKc0QGMvaTal8j/branch/BBGNHLvioA5YyXpSDf53U6/PrestaShop-Design-Kit?type=design&node-id=22210-12&mode=design&t=KEPCnGb3jL1FqT5W-0
Zero Height : https://docs.uikit.prestashop.com/34f250d18/p/97a2c2-notification-bar/b/32e1a2
Related Ticket : START-346

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@ga-devfront ga-devfront added Feature Type: New Feature WIP Status: Work In Progress labels Dec 15, 2023
@mattgoud mattgoud merged commit 1286356 into main Feb 15, 2024
5 checks passed
@mattgoud mattgoud deleted the feat/notification-bar branch February 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Type: New Feature WIP Status: Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants