Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: icon added to alert button #285

Closed
wants to merge 2 commits into from

Conversation

ClaraLpresta
Copy link
Contributor

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@ClaraLpresta ClaraLpresta requested a review from mattgoud January 5, 2024 13:58
Copy link
Contributor

@cnavarro-prestashop cnavarro-prestashop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok for me but if we begin to add every props of button in alert component, wouldn't that be better if we give possibility to precise a slot with only button component instead ? @mattgoud / @MikeLebeau your point of view on this please ?

@cnavarro-prestashop
Copy link
Contributor

@ClaraLpresta : I close this pull request because it's a duplicata of #246

@mattgoud
Copy link
Collaborator

It seems ok for me but if we begin to add every props of button in alert component, wouldn't that be better if we give possibility to precise a slot with only button component instead ? @mattgoud / @MikeLebeau your point of view on this please ?

prΓ©fΓ©rence slot pour ma part ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants