Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disabled state to icon #294

Merged
merged 2 commits into from
Jan 29, 2024
Merged

feat: add disabled state to icon #294

merged 2 commits into from
Jan 29, 2024

Conversation

MikeLebeau
Copy link

Related to this issue

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@MikeLebeau MikeLebeau requested a review from mattgoud January 16, 2024 14:33
@MikeLebeau MikeLebeau force-pushed the feat_add_disable_state_icon branch from 7790f5b to 8a6fee8 Compare January 16, 2024 14:48
kktos
kktos suggested changes Jan 16, 2024
View reviewed changes
packages/components/icon/src/icon.vue Outdated Show resolved Hide resolved
@mattgoud mattgoud linked an issue Jan 17, 2024 that may be closed by this pull request
[Feature] Add a disabled property on Icon #213
Closed
@mattgoud mattgoud assigned mattgoud and MikeLebeau and unassigned mattgoud Jan 19, 2024
@MikeLebeau MikeLebeau force-pushed the feat_add_disable_state_icon branch from 8a6fee8 to b9cc934 Compare January 22, 2024 15:15
@MikeLebeau MikeLebeau requested a review from kktos January 22, 2024 15:20
@MikeLebeau MikeLebeau force-pushed the feat_add_disable_state_icon branch from b9cc934 to ea7a2e4 Compare January 22, 2024 15:21
kktos
kktos previously approved these changes Jan 22, 2024
View reviewed changes
@MikeLebeau MikeLebeau force-pushed the feat_add_disable_state_icon branch from ea7a2e4 to 2546846 Compare January 23, 2024 10:01
@MikeLebeau MikeLebeau requested a review from kktos January 24, 2024 09:42
kktos
kktos previously approved these changes Jan 24, 2024
View reviewed changes
@MikeLebeau MikeLebeau force-pushed the feat_add_disable_state_icon branch from 2546846 to 651f07d Compare January 29, 2024 12:34
@mattgoud mattgoud merged commit 1bdcedf into main Jan 29, 2024
5 checks passed
@mattgoud mattgoud deleted the feat_add_disable_state_icon branch January 29, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgoud mattgoud mattgoud approved these changes

@kktos kktos kktos left review comments

Assignees

@MikeLebeau MikeLebeau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add a disabled property on Icon
3 participants
@MikeLebeau @kktos @mattgoud