Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #308 [tooltip][breaking-change] - prop naming - replace title b… #309

Merged
merged 23 commits into from
Feb 9, 2024
Merged

fix: #308 [tooltip][breaking-change] - prop naming - replace title b… #309

merged 23 commits into from
Feb 9, 2024

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Feb 6, 2024

…y heading

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

Mike Lebeau and others added 20 commits January 23, 2024 11:00
feat: add disabled state to icon
99db4b3
@ClaraLpresta
feat: articles variant added to link component
b1b0a42
feat: allow to use tailwindconf inside componenent
651f07d
@mattgoud
fix: #304 update storybook + refacto syntax of the table emits defini…
f2c5d6e 
…tions
@mattgoud
build: update pnpm-lockfile
fd2cfb5
@mattgoud
fix: rollback syntax of table emit definitions
120829e
@mattgoud
Merge pull request #294 from PrestaShopCorp/feat_add_disable_state_icon
1bdcedf 
feat: add disabled state to icon
@mattgoud
Merge branch 'main' into 304-table-update-storybook
ac67bcd
@mattgoud
Merge branch 'main' into feat/link-article
3a81a89
@ClaraLpresta
fix: articles added to link component storybook
5f5fbbf
@mattgoud
Merge pull request #302 from PrestaShopCorp/feat/link-article
f466985 
feat: articles variant added to link component
@mattgoud
Merge branch 'main' into 304-table-update-storybook
59c16ca
@mattgoud
Merge pull request #305 from PrestaShopCorp/304-table-update-storybook
7015698 
fix: #304 update storybook
@mattgoud
fix: rollup-config
46aefe4
@mattgoud
test: update icon test (check disabled class)
63c2434
@mattgoud
build: remove rollup-plugin-polyfill-node plugin
f1ea72b
@mattgoud
Merge pull request #306 from PrestaShopCorp/fix-rollup-config
8dd9a88 
Fix rollup config
@mattgoud
fix: #303 - change badge colors
b47ed99
@mattgoud
fix: #308 [tooltip][breaking-change] - prop naming - replace title by…
bb3e599 
… heading
@mattgoud
Merge pull request #307 from PrestaShopCorp/style/status-tag-update-c…
65acfc9 
…olors

fix: #303 - change badge colors
@mattgoud mattgoud self-assigned this Feb 6, 2024
@mattgoud mattgoud linked an issue Feb 6, 2024 that may be closed by this pull request
[BUG] [Tooltip] naming conflict between prop and native Html title attribute #308
Closed
@mattgoud mattgoud changed the base branch from main to feat/2.0.0-beta February 8, 2024 10:21
@mattgoud mattgoud merged commit 77aad89 into feat/2.0.0-beta Feb 9, 2024
1 check passed
@mattgoud mattgoud deleted the 308-bug-tooltip-naming-conflict-between-prop-and-native-html-title-attribute branch February 9, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnavarro-prestashop cnavarro-prestashop cnavarro-prestashop approved these changes

Assignees

@mattgoud mattgoud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [Tooltip] naming conflict between prop and native Html title attribute
3 participants
@mattgoud @cnavarro-prestashop @ClaraLpresta