Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom label reactivity corrected #314

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

ClaraLpresta
Copy link
Contributor

@ClaraLpresta ClaraLpresta commented Feb 19, 2024

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Suite à la dernière mise à jour de vue3, il y a un problème sur la réactivité du champ select.
Ce fix permet de palier à ce problème.

La props n'est pas réactive au premier changement dans une computed, je l'ai donc directement utilisé dans la template

Suite à ce fix, le champs affiche le bon customLabel dès le premier changement

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud merged commit 4692c03 into main Feb 27, 2024
3 of 5 checks passed
@mattgoud mattgoud deleted the fix/select-reactive-variable branch February 27, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants