Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: disable-border props alert in stories + id not required for tag #323

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

kevin-carangeot
Copy link
Contributor

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Required id in tag: Don't need to set it to make the component works, so don't put it as required
  • disabled-border: Fix documentation, props name is disable-border

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@kevin-carangeot kevin-carangeot added documentation Improvements or additions to documentation p2-nice-to-have Priority 2: Nice to have for next release labels Mar 19, 2024
@kevin-carangeot kevin-carangeot self-assigned this Mar 19, 2024
@kevin-carangeot kevin-carangeot changed the title fix: disable-border props alert in stories + id not required for tag docs: disable-border props alert in stories + id not required for tag Mar 19, 2024
Copy link
Collaborator

@mattgoud mattgoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattgoud mattgoud merged commit e5dab64 into main Mar 19, 2024
3 of 5 checks passed
@mattgoud mattgoud deleted the fix/props-alert-stories branch March 19, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p2-nice-to-have Priority 2: Nice to have for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants