Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

352 style button group remove gray border from buttons in active state #353

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Jul 3, 2024

Button-group

  • style : remove gray border from buttons in active state
  • style : remove left borders for buttons except for the first (to keep a thickness of 1 pixel between the buttons)

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud merged commit 144ee04 into main Jul 4, 2024
3 of 5 checks passed
@mattgoud mattgoud deleted the 352-style-button-group-remove-gray-border-from-buttons-in-active-state branch July 4, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] [Button-group] - remove gray border from buttons in active state
2 participants