Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build puik component import css #359

Merged
merged 19 commits into from
Jul 26, 2024
Merged

Build puik component import css #359

merged 19 commits into from
Jul 26, 2024

Conversation

mattgoud
Copy link
Collaborator

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud linked an issue Jul 11, 2024 that may be closed by this pull request
[BUG] [Puik-component-package] - [build-prod] - css of Vue components is not injected #358
Closed
mattgoud added 12 commits July 12, 2024 09:28
@mattgoud
build: related #358 - update tests CI (path for import css files)
7ae2558
@mattgoud
build: related #358 - vitest config - change resolve.alias for theme …
59a6d68 
…package
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
0530e83 
…css files
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
926c549 
…css files (2)
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
3b1b43e 
…css files (3)
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
cf8f2fe 
…css files (4)
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
c424c0e 
…css files (5)
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
ab19728 
…css files (6)
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
5b52c6b 
…css files (7)
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
d80ffe7 
…css files (8)
@mattgoud
ci: related #358 - vitest config - try to fix path failed for import …
5af3ac4 
…css files (9)
@mattgoud
ci: related #358 - workflow ci.yml : remove debug steps
310aeed
@mattgoud mattgoud requested a review from guillaume60240 July 12, 2024 12:08
@mattgoud mattgoud merged commit 14bbefa into main Jul 26, 2024
3 of 5 checks passed
@mattgoud mattgoud deleted the build-puik-component-import-css branch July 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaume60240 guillaume60240 guillaume60240 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [Puik-component-package] - [build-prod] - css of Vue components is not injected
2 participants
@mattgoud @guillaume60240