Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve-Accessibility] - fixed #346 #317 #363 #368

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Aug 9, 2024

📚 Description

Improve accessibility - fixed : #346 #317 #363

Fix all accessibility violations

ℹ️ see accessibility sections in Storybook to see the tests (chromatic build here)

⚠️ Exceptions:

New props

Components New props (all optional so no BC)
Alert ariaLive
Avatar ariaLabel
Badge ariaLive, ariaLabel
Button ariaLabel, disabledReason
Card ariaLabel
Checkbox ariaLabel, srLabel
Icon ariaLabel
Input ariaLive, ariaLabel, srLabel
Link ariaLabel
Radio ariaLabel, id, ariaDescribedby, srDescriptionOnly
Switch srLabel
Textarea ariaLabel

NB: other aria-* and role attributes have also been added internally

Keyboard handling improvements

  • Content extended/reduced (Accordeon)
  • Focus content with tab especially for screen readers (Alert, Avatar, Badge, Card, Chip)
  • Toggle password visibility (Input password)
  • closeEvent (Chip)
  • open Tooltip on focus

Others

Modal: fix #317 + responsive improvement
Table: fix #363

  • Add additional Unit Tests, update Storybook documentation
  • update Storybook config

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud changed the title feat: [Improve-Accessibility] - related #346 #317 (wip) [Improve-Accessibility] - fixed #346 #317 #363 Sep 4, 2024
@mattgoud mattgoud marked this pull request as ready for review September 4, 2024 16:50
@mattgoud mattgoud requested a review from sLorenzini September 4, 2024 16:51
@mattgoud mattgoud self-assigned this Sep 5, 2024
@mattgoud mattgoud merged commit 8eddf24 into main Sep 18, 2024
5 checks passed
@mattgoud mattgoud deleted the 346-feature-accessibility-no-possibility-to-read-select-content-on-components branch September 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant