-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve-Accessibility] - fixed #346 #317 #363 #368
Merged
mattgoud
merged 13 commits into
main
from
346-feature-accessibility-no-possibility-to-read-select-content-on-components
Sep 18, 2024
Merged
[Improve-Accessibility] - fixed #346 #317 #363 #368
mattgoud
merged 13 commits into
main
from
346-feature-accessibility-no-possibility-to-read-select-content-on-components
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooltip components
…Label, update storie (add ariaLive prop description)
… props, update doc (storie)
…] reorder btn, [Sidebar] fix ARIA attributes violation, [option] focus style
This was
linked to
issues
Sep 4, 2024
mattgoud
changed the title
feat: [Improve-Accessibility] - related #346 #317 (wip)
[Improve-Accessibility] - fixed #346 #317 #363
Sep 4, 2024
…read-select-content-on-components
…read-select-content-on-components
…read-select-content-on-components
…read-select-content-on-components
mattgoud
deleted the
346-feature-accessibility-no-possibility-to-read-select-content-on-components
branch
September 18, 2024 13:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Improve accessibility - fixed : #346 #317 #363
Fix all accessibility violations
ℹ️ see accessibility sections in Storybook to see the tests (chromatic build here)
Select
andPagination
components (for theLarge
variant which depends onSelect
) - see issue [Feature] [Accessibility] - Select component to update #361Chip
(disabled state),Tag
(disabled state),Table
(sticky option) - see issue [Feature] [Accessibility] - Low contrast on components #348 (waiting for design)New props
NB: other
aria-*
androle
attributes have also been added internallyKeyboard handling improvements
Accordeon
)Alert
,Avatar
,Badge
,Card
,Chip
)Input password
)Chip
)Tooltip
on focusOthers
Modal
: fix #317 + responsive improvementTable
: fix #363❓ Types of changes
📝 Checklist