Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [puik-alert] fix #339 - fix alert design specs (link button text), ability to add icons for buttons (Action and Link) #381

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Oct 3, 2024

Description

⚠️ fix alert design specs: by replacing the link (puik-link) by a Link Button (text variant)

⚠️ Finally no action slot to limit BC

News optional props (see updated stories for use) :
related to Action Button: rightIconBtn, leftIconBtn, AriaLabelBtn
related to Link Button: internalLink, externalLink , rightIconLink, leftIconLink, AriaLabelLink

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

…nal props instead (right/left icons and aria-label for linkButton/ActionButton), design in line with the figma model (button for the link)
@mattgoud mattgoud linked an issue Oct 3, 2024 that may be closed by this pull request
@mattgoud mattgoud merged commit e949052 into main Nov 19, 2024
3 of 5 checks passed
@mattgoud mattgoud deleted the 339-alert-breaking-change-create-an-action-slot branch November 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alert] [Breaking-change] create an action slot
3 participants