Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/384 select global refactoring #394

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Feat/384 select global refactoring #394

wants to merge 40 commits into from

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Dec 17, 2024 •
edited
Loading

❓ Types of changes

Global refactoring of Select component:
related issues :
#385
#384
#361
#287
#284
#280
#196

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

mattgoud added 30 commits October 14, 2024 21:05
@mattgoud
feat: [Select] - related #384 - global refacto (wip)
35d50b6
@mattgoud
feat: [Select] - related #384 - global refacto (style wip)
1db2e5b
@mattgoud
feat: [Select] - related #384 - add translations, style(wip), add new…
e9c0083 
… props(disabled feature)
@mattgoud
feat: [Select] - related #384 - initialize selectedOptions with model…
7a31706 
…Value prop
@mattgoud
feat: [Select] - related #384 - change puik-option logic (select even…
97d236f 
…t), fix weird behavior of selectAll feature (handle disabled options case)
@mattgoud
feat: [Select] - related #384 - separate v-model refs between single …
2244ca4 
…and multi select (selectedSingleOption/selectedMultipleOptions), style puik-select
@mattgoud
feat: [Select] - related #384 - implement puik-option via slot
bb50b56
@mattgoud
feat: [Select] - related #384 -fix puik-option reactivity when using …
ce8102a 
…in slot mode
@mattgoud
feat: [Select] - replace v-if directive by v-show instead to display …
ca4bd8b 
…options
@mattgoud
feat: [refacto-select] #384 - change select payload if option is dese…
193e308 
…lected
@mattgoud
feat: [refacto-select] #384 - add close event (option) and open event…
7a99358 
… (select)
@mattgoud
feat: [refacto-select] #384 - create puik-group-options component, fi…
b9c74d8 
…x translations
@mattgoud
feat: [refacto-select] #384 - improve accessibility, keyboard handlin…
3461d27 
…g (wip), add select label and error
@mattgoud
feat: [select] - related #384 - form case to send data : add value in…
07e8145 
… hidden inputs
@mattgoud
feat: [selet-refacto] - related #384 - improve searcheable feature (f…
bc9d181 
…ilteredOptions with custom method, filtering by optionLabelKey instead default label)
@mattgoud
Merge branch 'main' into feat/384-select-global-refactoring
b55a3e6
@mattgoud
feat: [select-refacto] - related #384 - fix style error input, improv…
301ab81 
…e keyboard handling (esc to close dropdown), fix reset search query feature when dropdown is closed
@mattgoud
feat: [select-refacto] - related #384 - improve accessiblity (ARIA ta…
2a9aebe 
…gs), add zIndex prop (group-options), styling focus on error puik-input-wrapper
@mattgoud
feat: [select-refacto] - related #384 - keyboard Handling (wip)
0f20fa3
@mattgoud
feat: [select-refacto] - related #384 - fix keyboard and mouse confli…
2af8313 
…ct behavior on selectAll handling
@mattgoud
feat: [select-refacto] - related #384 - fix toggleSelectAll feature f…
40d743a 
…or disabled options cases
@mattgoud
feat: [select-refacto] - related #384 - close dropdown on tab keydown
0e1f032
@mattgoud
feat: [select-refacto] - add bg-red-50 on Input error, add prependInp…
deaf119 
…utIcon prop, improve search autocomplete function
@mattgoud
feat: [select-refacto] - handle case where selectedOptions are not an…
657258a 
… OptionType but a string or a number, wip: implement jumper en itemsperpage selects in pagination-large component
@mattgoud
feat: [select-refacto][pagination-large]- fix select components in pa…
dff2984 
…gination (large variant)
@mattgoud
feat: [select-refacto] : if the dropdown is displayed outside the vie…
5293e45 
…wport, display it above the select -[pagination]- add id prop
@mattgoud
feat: [pagination] - add test (id prop), and update stories
f113922
@mattgoud
feat: [select-refacto] - add dataTest and name props
c775553
@mattgoud
docs: [select-refacto] - update stories
9d6789f
@mattgoud
feat: [select-refacto] - search feature: display no results placehold…
79ecdc6 
…er, fix aria-controls issue (need hidden it if dropdown is closed)
@mattgoud mattgoud added Feature Type: New Feature bug Something isn't working documentation Improvements or additions to documentation refactoring breaking change accessibility labels Dec 17, 2024
@mattgoud mattgoud self-assigned this Dec 17, 2024
This was linked to issues Dec 17, 2024
[Select] - Global refactoring #384
Open
[select] ajout event dropdown #385
Open
[Feature] [Accessibility] - Select component to update #361
Open
[BUG] : reactivity problem on the component select with a custom label #287
Open
[Select] multiple select feature #284
Open
[BUG][FEATURE][Searchable Select] Update filtered items with a third-party component #280
Open
[BUG] Component Select : value not selected when click on element by search bar #196
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattgoud mattgoud

Labels
accessibility breaking change bug Something isn't working documentation Improvements or additions to documentation Feature Type: New Feature refactoring
Projects
None yet
Milestone
No milestone
1 participant
@mattgoud