-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
affiliate grant year ranges on profile list pages are incorrect #197
Comments
moving out of v2.7 since there's not an easy solution and right now it only affects a few profiles. |
|
Including grant year ranges created a mismatch between the years listed and the name of the grant shown, which was only the most recent one. See #197
Including grant year ranges created a mismatch between the years listed and the name of the grant shown, which was only the most recent one. See #197
Including grant year ranges created a mismatch between the years listed and the name of the grant shown, which was only the most recent one. See #197
@thatbudakguy Looks fine! Only thing is that the link to Reischl's page in Slavic doesn't work. Here is the new link: https://slavic.princeton.edu/people/katherine-hill-reischl |
this is issue affects the display of grant information on the profiles of current affiliates. because the page tries to display the full range of years that someone has had any grant (for example, S&Co. has had grants for 5+ years), it creates a year range to display.
the issue is that it only displays the name of the most recent grant, so it will write something like
2015-2021 Dataset Curation Grant
which is wrong - the dataset curation grant was only for 2021.the easiest solution for now is to simply not display the range, so that the information is at least technically correct. thus people who got multiple grants will only display the most recent one, i.e.
2021 Dataset Curation Grant
.when we have a workable solution to display ranges again, that will be tracked on #222.
for more context, see slack conversation: https://cdhprinceton.slack.com/archives/C2VHT183A/p1599587576088900
testing notes
The text was updated successfully, but these errors were encountered: