Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

affiliate grant year ranges on profile list pages are incorrect #197

Closed
thatbudakguy opened this issue Sep 2, 2020 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@thatbudakguy
Copy link
Contributor

thatbudakguy commented Sep 2, 2020

this is issue affects the display of grant information on the profiles of current affiliates. because the page tries to display the full range of years that someone has had any grant (for example, S&Co. has had grants for 5+ years), it creates a year range to display.

the issue is that it only displays the name of the most recent grant, so it will write something like 2015-2021 Dataset Curation Grant which is wrong - the dataset curation grant was only for 2021.

the easiest solution for now is to simply not display the range, so that the information is at least technically correct. thus people who got multiple grants will only display the most recent one, i.e. 2021 Dataset Curation Grant.

when we have a workable solution to display ranges again, that will be tracked on #222.

for more context, see slack conversation: https://cdhprinceton.slack.com/archives/C2VHT183A/p1599587576088900

testing notes

  • Josh and Kat Reichl are good candidates to test this with, since both of them are currently displaying ranges that are incorrect in production.
  • All profiles on the affiliates page in the "current" section should only display the most recent grant (so all dates should be this academic year).
  • All profiles on the affiliates page in the "past" section should be unchanged; just give a quick to look to make sure that nothing looks off.
@thatbudakguy thatbudakguy added this to the v2.7 milestone Sep 2, 2020
@thatbudakguy thatbudakguy self-assigned this Sep 2, 2020
@thatbudakguy thatbudakguy removed their assignment Sep 10, 2020
@thatbudakguy thatbudakguy removed this from the v2.7 milestone Sep 10, 2020
@thatbudakguy
Copy link
Contributor Author

moving out of v2.7 since there's not an easy solution and right now it only affects a few profiles.

@thatbudakguy thatbudakguy added this to the v2.8 milestone Oct 16, 2020
@thatbudakguy
Copy link
Contributor Author

thatbudakguy commented Oct 27, 2020

if we implement the simplest fix (just display most recent grant), need to make an enhancement to later improve the display again. see #222

thatbudakguy added a commit that referenced this issue Nov 2, 2020
Including grant year ranges created a mismatch between the years
listed and the name of the grant shown, which was only the
most recent one.

See #197
@thatbudakguy thatbudakguy self-assigned this Nov 2, 2020
thatbudakguy added a commit that referenced this issue Nov 2, 2020
Including grant year ranges created a mismatch between the years
listed and the name of the grant shown, which was only the
most recent one.

See #197
thatbudakguy added a commit that referenced this issue Nov 4, 2020
Including grant year ranges created a mismatch between the years
listed and the name of the grant shown, which was only the
most recent one.

See #197
@cvansant
Copy link

cvansant commented Nov 5, 2020

@thatbudakguy Looks fine! Only thing is that the link to Reischl's page in Slavic doesn't work. Here is the new link: https://slavic.princeton.edu/people/katherine-hill-reischl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants