Remove grant year ranges from profile card display #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatbudakguy
force-pushed
the
affiliate-ranges
branch
from
6433b36 to
05ad078
Compare
Codecov Report
@@ Coverage Diff @@
## develop #223 +/- ##
===========================================
+ Coverage 97.85% 98.13% +0.27%
===========================================
Files 85 84 -1
Lines 2848 2839 -9
===========================================
- Hits 2787 2786 -1
+ Misses 61 53 -8 |
rlskoeser
reviewed
Nov 3, 2020
| {% firstof profile.first_start.year profile.first_start|slice:":4" as start_year %} | ||
| {% firstof profile.last_end.year profile.last_end|slice:":4" as end_year %} | ||
| {{ start_year }}{% if start_year != end_year %}–{{ end_year }}{% endif %} | ||
| {{ end_year }} |
There was a problem hiding this comment.
seems a little weird to me not to display the start/end year range for the most recent grant, but I guess this works as a simple, temporary solution
There was a problem hiding this comment.
you're right! it also simplified things a ton to just use start/end for most recent grant. i've changed it. thanks!
rlskoeser
approved these changes
Nov 3, 2020
Including grant year ranges created a mismatch between the years listed and the name of the grant shown, which was only the most recent one. See #197
thatbudakguy
force-pushed
the
affiliate-ranges
branch
from
05ad078 to
dcad38e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including grant year ranges created a mismatch between the years
listed and the name of the grant shown, which was only the
most recent one.
See #197