19 site search

[thatbudakguy]

This PR implements the site search page (#19). For designs, see:

• Search Form on Figma
• Search Results on Figma

I tried to interpret the search form and how it would fit into the page as best I can, but I think some more discussion is needed to disambiguate the form on this page from the one in #359, which will appear in the top navigation bar (and is not part of this issue).

Would appreciate advice on things like the placeholder text and "no results found" text. The page also doesn't have a title (or rather, the default title of "Search" is hidden) — should it be visible instead?

[codecov-commenter]

Codecov Report

Merging #372 (731a478) into develop (7c66f36) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #372      +/-   ##
===========================================
+ Coverage    98.18%   98.23%   +0.05%     
===========================================
  Files           88       89       +1     
  Lines         3638     3747     +109     
===========================================
+ Hits          3572     3681     +109     
  Misses          66       66              

[rlskoeser]

Looks good. A few questions and suggestions, no major concerns.

Not sure if it's in scope for this PR, but looks like it would be easy to add a site search config like we did for PPA; would be great to add at some point. See: https://github.com/Princeton-CDH/ppa-django/blob/main/templates/base.html#L23-L26

[rlskoeser]

Forgot to respond to your questions (although I feel like they are more for Gissoo than for me).

Would appreciate advice on things like the placeholder text and "no results found" text. The page also doesn't have a title (or rather, the default title of "Search" is hidden) — should it be visible instead?

• It looks a little weird to me not to have a title, I vote make it visible
• No results found text looks good to me.
• Placeholder text could be improved; I think I liked the version you had in the prototype better — didn't you list the kinds of content that were searchable? Or, if we don't want to specify what content is searchable maybe we can provide more guidelines about how to search — maybe "search by keyword or phrase" (if phase search is supported)?

[thatbudakguy]

added OpenSearch stuff from PPA, thx for mentioning that

[thatbudakguy]

Placeholder text could be improved; I think I liked the version you had in the prototype better — didn't you list the kinds of content that were searchable?

fwiw i did too, but it turned out to be too long on mobile 😞