Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved read_mesh/sources/receivers to the IO/interface.hpp #196

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Nov 27, 2024

Description

Just moving things around.

Issue Number

Closes #192

Closes #181

Closes #185

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert the source files, good point. Nothing will change except the CMakeLists.txt.

Sounds good. Otherwise the PR LGTM.

@icui icui merged commit b5f6350 into devel Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants