Update for MPI_PARALLEL flag #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/specfem_mpi/specfem_mpi.hpp
Outdated
| @@ -18,7 +18,10 @@ namespace MPI { | |||
| * Incase specfem is compiled without MPI then I need placeholders for reducer | |||
| * types | |||
| */ | |||
| enum reduce_type { sum = MPI_SUM, min = MPI_MIN, max = MPI_MAX }; | |||
| using reduce_type = MPI_Op; | |||
| const MPI_Op sum = MPI_SUM; | |||
There was a problem hiding this comment.
I think you'd need constexpr static MPI_Op here.
There was a problem hiding this comment.
I think the compilation will fail when MPI is enabled if tis a const MPI_OP itd have it be a static variable. Constexpr since we already know it at compile time
There was a problem hiding this comment.
constexpr wouldn't compile
Rohit-Kakodkar
requested changes
Dec 2, 2024
|
retest please |
Closed
|
retest please |
|
Retest this please |
|
@icui the tests won’t rerun on this. Since it’s being merged into a ‘issue-*’ branch. You should merge this PR if ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the changes/features in this pull request.
Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.
[] I ran the code through pre-commit to check style
[] My code passes all the integration tests
[] I have added sufficient unittests to test my changes
[] I have added/updated documentation for the changes I am proposing
[] I have updated CMakeLists to ensure my code builds
[] My code builds across all platforms