Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 394 src rcv python #397

Open
wants to merge 25 commits into
base: issue-228-anisotropy
Choose a base branch
from

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Jan 15, 2025

Description

Pull request for sources and receivers defined through Python.

Issue Number

Closes #394

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade
Copy link
Collaborator Author

lsawade commented Jan 16, 2025

Both Sources and receivers can now be defined from python. see specfempp-py repo.

@lsawade lsawade mentioned this pull request Jan 16, 2025
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* specfem::receiver::receiver * object
*
* The receivers are defined in the YAML file as
*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add @code and @Endcode doxygen directives here

@lsawade
Copy link
Collaborator Author

lsawade commented Jan 17, 2025

The recent updates change the source-file parameter to sources and it now can now be either a YAML node or a string pointing to a file.

@lsawade
Copy link
Collaborator Author

lsawade commented Jan 17, 2025

The updates also include zero-padded filenaming for the plotter output

@lsawade
Copy link
Collaborator Author

lsawade commented Jan 17, 2025

Finally I have updated the stations-file parameter to be named stations so that both receivers and stations follow the same pattern (almost)

receivers:
    stations: path/to/receiver_file || yaml node

sources:
    sources: path/to/source_file || yaml node

@lsawade
Copy link
Collaborator Author

lsawade commented Jan 17, 2025

there are a lot of files changed, but it's all specfem_config.yamls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants