Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate meshfem #93

Merged
merged 15 commits into from
Oct 31, 2023
Merged

Integrate meshfem #93

merged 15 commits into from
Oct 31, 2023

Conversation

Rohit-Kakodkar
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar commented Oct 31, 2023

Description

This pull request integrates meshfem2D into this code-base. Currently, we only support fortran mesher for meshing. Previous to this update the mesher was located in fortran specfem2d code-base - requiring the user to install and navigate 2 different code bases for meshing and solver.

This update should streamline the SPECFEM++ usage and would lead to easier adoption.

Issue Number

If there is an issue created for these changes, link it here

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

Added meshfem2d to the repository. Built a cmake build system around meshfem to compile xmeshfem. Haven't yet tested meshfem.
This update integrates meshfem2d into the current code base. Following changes were made:
1. Moved meshfem into meshfem2d folder
2. Cmake build system for meshfem
3. Removed redundant parameters from Par_file not needed for meshfem
4. Updated examples to use meshfem rather than using database files directly
@Rohit-Kakodkar Rohit-Kakodkar merged commit 46cad7e into code-along Oct 31, 2023
5 of 6 checks passed
@Rohit-Kakodkar Rohit-Kakodkar deleted the integrate-meshfem branch November 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant