mclo.gs upload #431
Open
mclo.gs upload #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
I know, I know. my code is garbage |
TheKodeToad
force-pushed
the
mclogs-upload
branch
from
e39c301 to
bf33ef0
Compare
TheKodeToad
force-pushed
the
mclogs-upload
branch
from
b719630 to
39186a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: when attachments are sent directly on Discord people usually ask the sender to upload on mclo.gs. Downloading files and opening them in a text editor can be a bit of a hassle (especially if you are on mobile, also I don't like downloading things constantly)
The new Info enum is designed so that we can add things like
launcher_version: Option<String>, loader: Option<String>If the user uploads a log which looks like a Minecraft or Launcher log, this prompt will show:
Otherwise, neither this prompt nor the no issues found message will appear.
If the user chooses to have their Minecraft log uploaded, this will appear once it has finished:
Sorry if this code is not the best, I realise the event handler functions are less concise now. I wanted to add a check to ensure the button is not pressed twice, but I did not manage to find a library or class which makes this easy