Fixed some CS1572, 1573, 1574 and 1591 warnings #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3fkn1ght
commented
Apr 17, 2020
dansiegel
requested changes
Apr 17, 2020
Adding comments per request of Dan Siegel
I have changed the file in an attempt to reduce the confusion identified by Dan Siegel
I have added the following comment to the key parameters
Added comment to the <param> tag for method documentation:: <param name="key">The key for the value to be returned</param> Added following comment tot he <returns> tag for method documentation: Returns a matching parameter of <typeparam name="T" /> if one exists in the Collection
Modified <param> tags on a few methods that check existence of keys/values or return values
Fixed Indentation
Updated comment for InitializationMode
Added <ref> clarification and <remarks> tag as requested by Dan Siegel
Update comment on ModuleState
Add ref summary info as reqeusted
|
I have made all the requested changes. Please review at your convenience. |
d3fkn1ght
commented
Apr 17, 2020
d3fkn1ght
commented
Apr 19, 2020
dansiegel
requested changes
Apr 19, 2020
I have added text to some of the tags as requested by Dan Siegel
|
I believe I have made all the required changes |
dansiegel
reviewed
Apr 20, 2020
I have added text to all the empty tags I found
Fixed a typo
|
Hopefull all the tags have text now. I apologize for missing that. |
dansiegel
reviewed
Apr 21, 2020
| public IEnumerable<string> Keys => | ||
| _entries.Select(x => x.Key); | ||
|
|
||
| /// <summary> | ||
| /// Adds the <paramref name="key" /> and <paramref name="value" /> to the KeyValuePair<string,object> collection |
There was a problem hiding this comment.
let's remove the paramref's from here...
Removed paramref
dansiegel
approved these changes
Apr 21, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed some CS1572, 1573, 1574 and 1591 warnings
Bugs Fixed
API Changes
None
Behavioral Changes
None
PR Checklist