Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved some CS1573,1591 #2073

Merged
merged 5 commits into from
Apr 24, 2020
Merged

Resolved some CS1573,1591 #2073

merged 5 commits into from
Apr 24, 2020

Conversation

WaldemarCoding
Copy link
Contributor

@WaldemarCoding WaldemarCoding commented Apr 21, 2020

Description of Change

Resolved some CS1573,1591 #1978

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

public interface INavigationParametersInternal
{
/// <summary>
/// Adds the key and value to the KeyValuePair<string,object> collection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is invalid markup... second we don't really want to reference the KeyValuePair's outright... just refer to them as parameters

@@ -1,11 +1,30 @@
namespace Prism.Navigation
{
/// <summary>
/// Internal - Provides a way for the <see cref="INavigationService"/> to pass parameteres during navigation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to set internal parameters used by Prism's NavigationService

/// <summary>
/// Adds the key and value to the KeyValuePair<string,object> collection
/// </summary>
/// <param name="key">The key to reference this value in the KeyValuePair<string, object></param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@dansiegel dansiegel merged commit 076a7cf into PrismLibrary:master Apr 24, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants