Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable nullability for core mvvm #3140

Merged
merged 2 commits into from
May 25, 2024
Merged

chore: enable nullability for core mvvm #3140

merged 2 commits into from
May 25, 2024

Conversation

RLittlesII
Copy link
Contributor

@RLittlesII RLittlesII commented May 15, 2024 •
edited
Loading

Description of Change

Enable Nullability for Prism MVVM folder

No Tests added, unless reviewer requests verification of behavior change not previously covered.

Bugs Fixed

  • Provide links to bugs here

API Changes

Changed:

  • BindableBase
  • ViewRegistry
  • ViewRegisration
  • ViewModelLocationProvider
  • PropertySupport

Behavioral Changes

Should be zero behavior changes because nullability is backwards compatible

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@RLittlesII RLittlesII marked this pull request as ready for review May 15, 2024 13:06
@dansiegel dansiegel merged commit e296a0a into PrismLibrary:master May 25, 2024
6 checks passed
@RLittlesII RLittlesII deleted the chore/nullability/mvvm branch May 26, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

@brianlagunas brianlagunas Awaiting requested review from brianlagunas brianlagunas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RLittlesII @dansiegel