Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible/bbb role #37
Ansible/bbb role #37
Changes from 48 commits
2e56850
329044d
622a8bb
4a9248d
991ec98
bb4c026
c02d7f1
b31c8ef
eb64e5f
5f14ad8
fb75a59
25c0ad4
e640d90
9b465af
e9a0ad1
3a53005
f2686f9
f4e71c7
48f7181
7458ed6
28eae25
995006b
5a4b271
6136c68
d5950b3
654ec16
4c4a8bd
a522472
19caf88
79b4f43
e0e9a18
2720b84
eb5b6a9
ca98303
1cef3eb
02edc02
bdfb5cc
181eb75
aad9d55
0838325
438f018
f5bbd74
7ef7b4c
0dc74ef
1635331
93fa142
33cea74
71e085f
f462860
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this tag do? I would assume it disables the idempotence molecule test as you referred to as having issues, but I don't see this tag being referenced anywhere. How does it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually instruct molecule to not check for idempotency on this specific role.
We could add an issue to look into it and make idempotency work for this role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine. It's just that I didn't see any code referencing this tag. Can you point me to the line where molecule does this? Or is it in the other commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://molecule.readthedocs.io/en/latest/configuration.html#id7
Molecule will skip tasks which are tagged with either molecule-notest or notest. With the tag molecule-idempotence-notest tasks are only skipped during the idempotence action step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks