Fix mailcow update task, add tags and improve README #47

anadahz · 2020-10-09T23:57:26Z

No description provided.

francisco-core · 2020-10-10T20:49:37Z

Thanks for working on this! Just a question: did you make sure that this doesn't break when installing for the first time?

anadahz · 2020-11-01T19:30:17Z

Thanks for working on this! Just a question: did you make sure that this doesn't break when installing for the first time?

@francisco-core The tasks with the tag update will only run if the update tag is specifie by ansible-playbook command (see the command example).

- Only install role if mailcow does not exist already - Refactor conditional statements - Add missing default variables

.travis.yml

ansible/roles/mailcow/defaults/main.yml

ansible/roles/mailcow/molecule/default/molecule.yml

francisco-core · 2021-01-27T14:28:45Z

ansible/roles/mailcow/molecule/default/molecule.yml

+  - name: debian10-instance
+    box: generic/debian10
+    memory: 2000
+    cpus: 1
+    groups:
+      - mailserver


Why are we doing deploy on 2?

This is an error, 2 different version of Debian should be tested.

anadahz · 2021-01-27T15:00:04Z

ansible/roles/mailcow/molecule/default/molecule.yml

+
+platforms:
+  - name: debian9-instance
+    box: generic/debian10


This should be changed to generic/debian9.

francisco-core · 2021-01-27T15:10:24Z

For me it's ready to merge. Let's just wait for travis to do its job.

- Switch to docker_compose as docker_service is deprecated - Add docker-compose pip module to molecule preparation stage

https://travis-ci.org/github/PrivacyLx/devops/jobs/757378337#L835

Changing docker mirror due to rate limits in pulls.

Since February the 28th 2017 mailcow does come with port 80 and 443 enabled. https://mailcow.github.io/mailcow-dockerized-docs/u_e-80_to_443/

francisco-core · 2021-02-07T09:28:38Z

@anadahz let me know when it's ready for review.

TODO: Make update tasks idempotent

The Debian images need to upgrade grub-pc, which cause a pop-up, breaking the update role. This issue affects only the testing generic Debian Vagrant images. See: adoptium/infrastructure#1980

Implement only for Molecule testing as Travis CI IP addresses often get rate limited.

anadahz · 2021-03-20T14:05:29Z

@francisco-core This is now ready to merge.
I have also fixed 2 new bugs in 2b1ddbc and 9939b94.

francisco-core

Just some minor questions / details, but other than that it's good to merge. Thank you for all the work done here!

ansible/inventory/molecule/group_vars/all/vars.yml

francisco-core · 2021-03-21T12:56:33Z

ansible/inventory/production/host_vars/mail.privacylx.org/vars.yml

-64343935313532643730613634653633373066616332326233383866613564643437323630383165
-37333139663266303366373732396366613766666230333730643638383532396435323639366662
-6364623030656639643964333361363735626162653861643931
+36366135343963646138626131313034343638366566386166353533316464623032353338636433


We don't have here a DOCKERHUB_USER and pass. Don't we need it defined here to avoid those rate-limits?

Please see my response in comment: https://github.com/PrivacyLx/devops/pull/47/files#r598289108

francisco-core · 2021-03-21T12:59:21Z

ansible/roles/bigbluebutton/molecule/default/prepare.yml

        state: latest
+
+    # Bug: https://github.com/pypa/get-pip/issues/83
+    - name: Install pip3.5 workaround


Given that on the host system we are installing python3-pip shouldn't we also install here just a generic pip version? like from https://bootstrap.pypa.io/get-pip.py? I don't see any easy way to keep these consistent. Though I can also see Debian saying well behind on pip compared to that official one.

Thanks for spotting this, this fix shouldn't be in this branch.

I removed this file in the commit: 76252b4

Well if it works, then it's good.

francisco-core · 2021-03-21T14:56:13Z

good to merge

anadahz · 2021-03-21T15:06:25Z

@francisco-core Thank you for the review, merging.

Fix mailcow update task, add tags and improve README

6de3699

anadahz requested review from francisco-core, gl00ten and kcg295 October 9, 2020 23:57

anadahz added 3 commits January 2, 2021 12:08

No install if mailcow exists, set defaults, refactor conditionals

b59f63b

- Only install role if mailcow does not exist already - Refactor conditional statements - Add missing default variables

Add Molecule testing for mailcow

a98ff60

Fix mailcow group host

96ea4d6

anadahz commented Jan 2, 2021

View reviewed changes

.travis.yml Show resolved Hide resolved

anadahz and others added 4 commits January 2, 2021 13:41

Add prepare playbook to satisfy molecule dependencies

c4c10e7

Fix linting, list cronjobs, remove duplicate dns check

b772d0a

Fix linting

135b727

Merge branch 'master' into mailcow/update

811cc74

francisco-core reviewed Jan 27, 2021

View reviewed changes

anadahz commented Jan 27, 2021

View reviewed changes

core and others added 2 commits January 27, 2021 15:01

make passwords static

94d7a21

Fix Vagrant platform box Debian version

3ca595c

francisco-core approved these changes Jan 27, 2021

View reviewed changes

anadahz and others added 10 commits January 28, 2021 09:25

Fix deprecation, satisfy molecule requirements

b6e154e

- Switch to docker_compose as docker_service is deprecated - Add docker-compose pip module to molecule preparation stage

Merge branch 'master' into mailcow/update

a57a87f

Check if any of mailcow's standard ports are in use

2f051de

Gather facts on listening ports

4acb781

Fail when mailcow ports are in use, add default vars

c018efa

Ensure postfix package is not installed

de9ab97

Add default vars, fix listing cron entries

bbe56eb

Update mailcow backup cron, add more default vars, fix cron printout

3636d0f

Fix indentation and linting

1e5aa5a

Remove non required cronjob

b8b4b73

anadahz added 13 commits February 3, 2021 09:22

Attempt to fix Python CI dependencies issues

46cbc8d

Fix: lookup for remote cronjob file

41600d3

Attempt to fix CI: Remove python deps install

0fd8ad4

Add default var, disable dns checkn in molecule, become once

ce5295f

Attempt to fix CI, add libffi-dev package dependency

d2e557e

https://travis-ci.org/github/PrivacyLx/devops/jobs/757378337#L835

Attempt to fix CI: add python dependencies

85b0bab

Change to docker mirror, attempt to fix python pkg deps

c3d5ee2

Changing docker mirror due to rate limits in pulls.

Remove nginx redir tasks, no idempotence checks for ports, fix CI

a8e5e64

Since February the 28th 2017 mailcow does come with port 80 and 443 enabled. https://mailcow.github.io/mailcow-dockerized-docs/u_e-80_to_443/

Call mailcow update tag on update role

ce4337f

Remove conficting tag, install pyopenssl via pip during prepare stage

63298eb

Fix tags

1fa5440

Test mailcow update tasks, install pip3.5 fix workaround

8a72ab9

Install python3 in prepare stage, fix molecule var

de109eb

anadahz added 4 commits March 19, 2021 21:30

Disable idempotency test of update tasks

5109ed4

TODO: Make update tasks idempotent

Prevent grub-pc package from being upgraded

2b1ddbc

The Debian images need to upgrade grub-pc, which cause a pop-up, breaking the update role. This issue affects only the testing generic Debian Vagrant images. See: adoptium/infrastructure#1980

Fix task syntax

e448f57

Add support for DockerHub login in order to not get rate limited in CI

9939b94

Implement only for Molecule testing as Travis CI IP addresses often get rate limited.

francisco-core reviewed Mar 21, 2021

View reviewed changes

Remove unrelated fix from the branch

76252b4

francisco-core approved these changes Mar 21, 2021

View reviewed changes

anadahz merged commit ad64f2a into master Mar 21, 2021

anadahz deleted the mailcow/update branch March 21, 2021 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mailcow update task, add tags and improve README #47

Fix mailcow update task, add tags and improve README #47

anadahz commented Oct 9, 2020

francisco-core commented Oct 10, 2020

anadahz commented Nov 1, 2020 •

edited

Loading

francisco-core Jan 27, 2021

anadahz Jan 27, 2021

anadahz Jan 27, 2021

francisco-core commented Jan 27, 2021

francisco-core commented Feb 7, 2021 •

edited

Loading

anadahz commented Mar 20, 2021

francisco-core left a comment

francisco-core Mar 21, 2021

anadahz Mar 21, 2021

francisco-core Mar 21, 2021

anadahz Mar 21, 2021

francisco-core Mar 21, 2021

francisco-core commented Mar 21, 2021

anadahz commented Mar 21, 2021

Fix mailcow update task, add tags and improve README #47

Fix mailcow update task, add tags and improve README #47

Conversation

anadahz commented Oct 9, 2020

francisco-core commented Oct 10, 2020

anadahz commented Nov 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francisco-core commented Jan 27, 2021

francisco-core commented Feb 7, 2021 • edited Loading

anadahz commented Mar 20, 2021

francisco-core left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francisco-core commented Mar 21, 2021

anadahz commented Mar 21, 2021

anadahz commented Nov 1, 2020 •

edited

Loading

francisco-core commented Feb 7, 2021 •

edited

Loading