Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust feedback form styles for dark mode compatibility and resolved conflicts #431

Closed
wants to merge 1 commit into from

Conversation

SiddarthaKarri
Copy link

Title of the Pull Request

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #359 and #385

Description

I made changes to the feedback form to support dark mode, including adjusting colors, button styles, and modal background transparency for better visibility.
Resolved the conflicts

Before:
image

After:
image

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have resolved all merge conflicts.

@PriyaGhosal I made the pull requests and resolved all the conflicts

Copy link

vercel bot commented Oct 11, 2024

Deployment failed with the following error:

Resource is limited - try again in 12 minutes (more than 100, code: "api-deployments-free-per-day").

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit cba5a30
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/6708f347e52a430008e98fab
😎 Deploy Preview https://deploy-preview-431--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal
Copy link
Owner

@SiddarthaKarri Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Bug in Dark Mode
2 participants