Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the Navbar Responsive for Small Size Displays - Merge Conflicts #590

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

AustinVarshney
Copy link
Contributor

Related Issue

closes: #558

Description

Made the Navbar Responsive for Small Size Displays in the Light theme. The improper indentation was due to extra margin was given and absolute position that was giving to the two button.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

List of Checkbox

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

Fix4

Fix5

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 8:21am

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit a611c02
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/67121a87a121e80008553788
😎 Deploy Preview https://deploy-preview-590--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal PriyaGhosal merged commit 9276ae4 into PriyaGhosal:main Oct 18, 2024
6 checks passed
@PriyaGhosal
Copy link
Owner

PriyaGhosal commented Oct 18, 2024

@AustinVarshney
image
Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar is not Responsive and needs to improved in its UI.
2 participants