Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navbar non functionality and alignment in career page #612

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

SubramanyaKS
Copy link
Contributor

Title of the Pull Request

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #611

Description

navbar was not aligned correctly and it was not functional on career page. so i fixed this issue.

Before:
image

After:
image

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have resolved all merge conflicts.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 11:41am

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit dc746a9
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/6712494fb32a7600089184f1
😎 Deploy Preview https://deploy-preview-612--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SubramanyaKS
Copy link
Contributor Author

Hi @PriyaGhosal ,

Please review and merge it?

Thank you.

IniyalPalanisamy added a commit to IniyalPalanisamy/SkillWise that referenced this pull request Oct 18, 2024
fix: navbar non functionality and alignment in career page PriyaGhosal#612 issue solved
@IniyalPalanisamy IniyalPalanisamy mentioned this pull request Oct 18, 2024
12 tasks
@SubramanyaKS
Copy link
Contributor Author

Hi @PriyaGhosal ,

Please review and merge it?

Thank you.

@anuragverma108 anuragverma108 merged commit d0de4b6 into PriyaGhosal:main Oct 19, 2024
6 checks passed
@anuragverma108
Copy link
Collaborator

Great work @SubramanyaKS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Navbar in career section is not working:
2 participants