Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #717 : searchbar now shows result when enter key is pressed #718

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

Irtesaam
Copy link
Contributor

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #717

Description

To search for a course, we have to click on the search icon using mouse to be able to search. To make it easier, I added 'enter key' functionality to directly search by pressing it rather than using mouse to click on the search icon.

Screenshots

Before :

issue.mp4

After :

resolved.mp4

Type of change

What sort of changes have you made:

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 9:07am

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit a861e3b
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/671376d604d2110008b7762c
😎 Deploy Preview https://deploy-preview-718--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anuragverma108 anuragverma108 merged commit c5e7340 into PriyaGhosal:main Oct 19, 2024
6 checks passed
@Irtesaam Irtesaam deleted the fix-searchbar branch October 20, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searchbar to be able to show results when pressing enter
2 participants