Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #753 : X icon in dark mode #754

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

Irtesaam
Copy link
Contributor

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #753

Description

Before : X icon was having sharp white corners which was visible in dark mode
Screenshot from 2024-10-20 14-18-35

After : Corners are rounded well making the UI consistent
image

Changes performed :
changed size of white fill in the svg of X-icon to fix it from appearing outside of logo.

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 9:48am

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit e767655
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/6714d1cd7fecdf0008a265a1
😎 Deploy Preview https://deploy-preview-754--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal PriyaGhosal merged commit 636434b into PriyaGhosal:main Oct 20, 2024
6 checks passed
@PriyaGhosal
Copy link
Owner

@Irtesaam Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. You can also contribute in my another Repository BuddyTrail which is also under Hacktoberfest
Great contribution to HACKTOBERFEST'24! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X icon inconsistency in dark mode
2 participants