Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar overlay adjusted for mobile view #759

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

Srikar-1729
Copy link
Contributor

Sidebar overlay adjusted for mobile viewing

Related Issue

Closes: #757

Description

I have changed the display width of the overlay so that the layout of the sidebar lies within the background overlay, enabling proper alignment for mobile view.

Before:

Items inside doesn't fit in
Screenshot 2024-10-20 162418
Unnecessary extra white space
Screenshot 2024-10-20 164502

After:

Corrected display for both:
Screenshot 2024-10-20 163537
Screenshot 2024-10-20 164613

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 11:22am

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit 374c239
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/6714e7f24feabc0008363786
😎 Deploy Preview https://deploy-preview-759--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal PriyaGhosal merged commit ddf76ac into PriyaGhosal:main Oct 20, 2024
6 checks passed
@PriyaGhosal
Copy link
Owner

@Srikar-1729 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. You can also contribute in my another Repository BuddyTrail which is also under Hacktoberfest
Great contribution to HACKTOBERFEST'24! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar overlay inconsistency for mobile view
2 participants