Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Buy our E-book" button visibility in night mode #867

Closed
wants to merge 1 commit into from

Conversation

megh-bari
Copy link
Contributor

Title of the Pull Request

fix: "Buy our E-book" button visibility in night mode

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #866

Description

The "Buy our E-book" button was not visible in night mode due to insufficient contrast with the background. Updated the button's CSS in assets\css\darkmode.css to ensure it has a suitable color in night mode for better visibility. Added a contrasting background color and text color to the button to maintain readability across themes.

After made Change how it look:

fix-issue-ebook.mp4

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 7:56am

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit 5871abb
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/671df2177c47260008298956
😎 Deploy Preview https://deploy-preview-867--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal
Copy link
Owner

@megh-bari Sorry, This issue has already been addressed Find another issue or feature to contribute to. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Buy our E-book" button is not visible in night mode
2 participants