Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bzlmod support #118

Merged
merged 6 commits into from
Oct 13, 2024
Merged

Add bzlmod support #118

merged 6 commits into from
Oct 13, 2024

Conversation

ljessendk
Copy link

This MR adds bzlmod support to bazel-latex.

A few changes were needed to do so:

  • rules_python has been bumped to latest version (version 0.36.0).
  • I had to disable the amd64-freebsd toolchain as this seems to be broken (missing the biber tool).
  • I have introduced a 'hub' repository for all the texlive packages.

@ljessendk ljessendk mentioned this pull request Oct 10, 2024
@Vertexwahn
Copy link
Contributor

Awesome!

@solsjo
Copy link
Collaborator

solsjo commented Oct 10, 2024

Great @ljessendk
Have not had time to review it/test it locally yet.

But if any of the others have time to review / merge I'll very much trust their verdict.

I did not see any commit updating the README, I think it would make sense to update that as well.

@solsjo
Copy link
Collaborator

solsjo commented Oct 10, 2024

@ljessendk
I triggered the test pipeline and currently,

  • buildifier check fails
  • mac os test faila to identify the ghost script target

Lars Sønderby Jessen added 5 commits October 11, 2024 15:06
Disable the amd64-freebsd as this toolchain seems to be missing the
biber binary.
Bump rules_python to version 0.9.0 to allow the project to build with
Bazel 7.3.1.
In preparation for supporting bzlmod the big latex_repositories() method
in repositories.bzl is split up into multiple parts.
Add a texlive 'hub' repository with an alias for each texlive
package. This has two purposes:
- It allows users to reference texlive packages without having to modify
and patch the packages/BUILD.bazel file.
- It will enable/ease a future migration to bzlmod.
To prepare for the migration to bzlmod we need to use a more recent
version of rules_python that uses the pip_parse() method instead of
the pip_install().
Implement bzlmod support. This fixes ProdriveTechnologies#116.
@ljessendk
Copy link
Author

@ljessendk I triggered the test pipeline and currently,

  • buildifier check fails
  • mac os test faila to identify the ghost script target

Both should be fixed now.
The 4 test pipelines still fail, but they fail with the same error as on the master branch.

@Vertexwahn
Copy link
Contributor

Vertexwahn commented Oct 13, 2024

I tested it successfully with Ubuntu 22.04 (on x64) and macOS Sonma (on M1)! Works great!

@solsjo I suggest to merge this!

@solsjo
Copy link
Collaborator

solsjo commented Oct 13, 2024

Agree! Great that you tested it @Vertexwahn! Havn't had time!

@solsjo
Copy link
Collaborator

solsjo commented Oct 13, 2024

I think dvisvgm fails because ghostscript is out-of-sync with ubuntu-latest. Which at the time of adding the dvisvgm targets probably was a prevous version of ubuntu.
Perhaps we ought to filter out the dvisvgm example targets for now?

@solsjo solsjo merged commit 227b02f into ProdriveTechnologies:master Oct 13, 2024
2 of 6 checks passed
@solsjo
Copy link
Collaborator

solsjo commented Oct 13, 2024

Thank you @ljessendk!

@solsjo
Copy link
Collaborator

solsjo commented Oct 13, 2024

@Vertexwahn the README should probably be update to reflect how to use the repo using bazel modules?

@Vertexwahn
Copy link
Contributor

@solsjo See here -> #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants