Move sample generation of README in its own package #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with building `//...` is that bazel downloads all the build toolchains, even though only one is useful for the host. By moving the sample generation in //sample, anyone can run `bazel build //sample/...` and only download what is needed to produce the README file in all formats. Also, exports PANDOC_FORMATS so that the rule and the sample use the same set of formats.
|
This change depends on #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #1, the problem with building
//...is that bazel downloads all the build toolchains, even though only one is useful for the host.By moving the sample generation in //sample, anyone can run
bazel build //sample/...and only download what is needed to produce the README file in all formats.Also, exports
PANDOC_FORMATSso that the rule and the sample use the same set of formats.