Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8267 fix normalize intensity #8286

Merged
merged 7 commits into from
Jan 20, 2025
Merged

8267 fix normalize intensity #8286

merged 7 commits into from
Jan 20, 2025
+25 −0

Conversation

advcu987
Copy link
Contributor

@advcu987 advcu987 commented Jan 8, 2025

Fixes #8267 .

Description

Fix channel-wise intensity normalization for integer type inputs.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@advcu987
Fixes Project-MONAI#8267 .
b55a02e 
    Fix channel-wise intensity normalization for integer type inputs.

    Signed-off-by: Adrian Voicu <[email protected]>
@advcu987
Revert " Fixes Project-MONAI#8267 ."
28a0df1 
This reverts commit b55a02e.
@advcu987
Fixes Project-MONAI#8267 .
bdb3604 
    Fix channel-wise intensity normalization for integer type inputs.

    Signed-off-by: Adrian Voicu <[email protected]>
@advcu987
:DCO Remediation Commit for advcu987 <[email protected]>
3656b99 
I, advcu987 <[email protected]>, hereby add my Signed-off-by to this commit: b55a02e
I, advcu987 <[email protected]>, hereby add my Signed-off-by to this commit: 28a0df1
I, advcu987 <[email protected]>, hereby add my Signed-off-by to this commit: bdb3604

Signed-off-by: advcu987 <[email protected]>
advcu987 and others added 2 commits January 14, 2025 15:39
@advcu987
Copy link
Contributor Author

@KumoLiu , @ericspod can this be merged?

@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 16, 2025

/build

ericspod
ericspod approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but we should add a comment in the docstring for the class stating that the conversion will be done to non-floating point inputs.

@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 17, 2025

Hi @advcu987, could you please try to add some comments based on @ericspod's comments? Then I could help merge the pr, thanks.

@advcu987
Add class comment.
63bd2b7 
Signed-off-by: advcu987 <[email protected]>
@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 20, 2025

/build

@KumoLiu KumoLiu merged commit e39bad9 into Project-MONAI:dev Jan 20, 2025
28 checks passed
@advcu987 advcu987 deleted the 8267-fix-normalize-intensity branch January 20, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu left review comments

@ericspod ericspod ericspod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

monai.transforms.intensity.array.NormalizeIntensity bug when __call__ with channel_wise=True
3 participants
@advcu987 @KumoLiu @ericspod