Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto update model_info [skip ci] #723

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Conversation

nvauto
Copy link
Collaborator

@nvauto nvauto commented Feb 5, 2025

This PR is automatically created to update model_info.json

@ericspod ericspod requested a review from KumoLiu February 5, 2025 15:34
@KumoLiu
Copy link
Collaborator

KumoLiu commented Feb 5, 2025

/build

@yiheng-wang-nv
Copy link
Collaborator

Hi @KumoLiu @ericspod , since the new added model requires an internal application (to host and make it public), let's block this PR merge so far, Thanks!
I will merge after getting approved.

@KumoLiu
Copy link
Collaborator

KumoLiu commented Feb 5, 2025

Hi @yiheng-wang-nv, please also request for this one: #721
Thanks.

@ericspod
Copy link
Member

ericspod commented Feb 6, 2025

Hi @KumoLiu @ericspod , since the new added model requires an internal application (to host and make it public), let's block this PR merge so far, Thanks! I will merge after getting approved.

Thanks @yiheng-wang-nv I'd like to get #722 through as well shortly so we can batch the three changes together I hope.

yiheng-wang-nv and others added 3 commits February 10, 2025 17:18
Fixes # .

### Description
A few sentences describing the changes proposed in this pull request.

### Status
**Ready/Work in progress/Hold**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

---------

Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes # .

### Description
A few sentences describing the changes proposed in this pull request.

### Status
**Ready/Work in progress/Hold**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

---------

Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@yiheng-wang-nv
Copy link
Collaborator

Hi @KumoLiu @ericspod , the application to host in NGC is blocked due to NGC's changes.
Therefore, I switched to host these three new bundles into github release instead.
I will submit a related PR in MONAI to adapt the changes.

@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv merged commit 44560c4 into dev Feb 24, 2025
4 checks passed
@yiheng-wang-nv yiheng-wang-nv deleted the auto-update-model-info branch February 24, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants