Fix NavMenu Icon for Compatibility with CiviCRM Core 5.77/Font Awesome 6

[Ben-Ro]

General

I couldn't find any specific contribution guidelines for this project, so I did my best to address this issue. If I missed any steps or requirements, just let me know :)

This PR addresses issue #434 with the NavMenu icon in the CiviBanking extension after upgrading to CiviCRM Core ^5.77. The recent upgrade introduced a major change in Font Awesome, shifting from version 4 to version 6, which deprecated several older class names, including fa fa-btc.

Changes Made

Utilized the crm-i wrapper for Font Awesome, as recommended in the CiviCRM developer documentation to maintain compatibility with future updates.

Testing

Manually verified that the NavMenu icon is displayed correctly after applying these changes on our CiviCrm System (attached screenshot)

[ufundo]

+1 for this. Even before the version upgrade, any use of Font Awesome in CiviCRM should use crm-i to avoid clashes with CMS implementations.

Worth noting there's a wider icon palette available with the update, so on 5.77+ you could also use e.g. https://fontawesome.com/icons/building-columns?f=classic&s=solid

In the long run generally good to update to v6 icon names to a) avoid the need for loading the v4 shim; b) allow users to opt out of the "brand" icons, like fa-btc.

[MarcMichalsky]

I can confirm that this works perfectly well! Thanks @Ben-Ro!

[bjendres]

Thanks @Ben-Ro and @MarcMichalsky, will be released soon

[jensschuppe]

Worth noting there's a wider icon palette available with the update, so on 5.77+ you could also use e.g. https://fontawesome.com/icons/building-columns?f=classic&s=solid

👍 for replacing the Bitcoin icon with the bank icon btw, although it's kind of appealing because of the common initial letter.

[bjendres]

👍 for replacing the Bitcoin icon with the bank icon btw, although it's kind of appealing because of the common initial letter.

I liked the Bitcoin-Icon...