Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define pseudo constant option group names in entities #441

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

dontub
Copy link
Collaborator

@dontub dontub commented Jan 9, 2025

This allows to use suffix fields like :name in APIv4 requests.

systopia-reference: 27461

This allows to use suffix fields like `:name` in APIv4 requests.
@dontub dontub requested review from bjendres and jensschuppe January 9, 2025 11:17
@bjendres
Copy link
Member

bjendres commented Jan 9, 2025

Looks good to me, even though it pains me to see that the OptionValue:id is still used - a blunder from over 10 years ago...sorry.

@bjendres bjendres added this to the CiviBanking 1.3 milestone Jan 17, 2025
@bjendres bjendres merged commit fb0f75b into master Jan 17, 2025
@bjendres
Copy link
Member

Looks sensible to me, thanks

Copy link
Member

@bjendres bjendres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants