Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts (Templates) and Pages #955

Closed
15 tasks
thescientist13 opened this issue Jul 1, 2022 · 1 comment · Fixed by #1212, #1208 or #1265
Closed
15 tasks

Layouts (Templates) and Pages #955

thescientist13 opened this issue Jul 1, 2022 · 1 comment · Fixed by #1212, #1208 or #1265
Assignees
Labels
alpha.3 breaking RFC Proposal and changes to workflows, architecture, APIs, etc v0.30.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jul 1, 2022

Type of Change

RFC

Summary

Worth thinking about reviewing any DX considerations for Templates and Pages.

Details

Things that come to mind:

  1. Templates as custom elements
  2. What to do about getTemplate and getBody if anything, now that we HTMLElement SSR support. Does it make sense to have multiple ways to SSR a page?
  3. what to do about current API signature ((compilation, page, request)) - Anyway to clean this up?
  4. rename getBody -> getPage?
  5. rename getFrontmatter -> getMetadata?
  6. Should templates be renamed to layouts? Seems more consistent.
  7. Evaluate frontmatter and <meta> (a la React helmet)
  8. Per evaluate (remove) use of Workers for SSR and prerendering #1088, templates are currently static only for SSR pages, but would be nice to change that - https://github.com/ProjectEvergreen/greenwood/pull/1110/files#diff-036193aa52a1863fc84a1878a4026f259d3605cdc9c0312d3dba861b80b7bb35R199
  9. Use <slot> instead of <content-outlet>? Or maybe not?
  10. What about custom page extensions, like .ts or .jsx?
  11. bundle context plugins for SSR
  12. Page level data - in replace of removing getPages / getTemplate along with Data Loading Strategies #952
  13. Trailing forward slash (/)
  14. APIs in the pages/ directory?
  15. refactor Greenwood context, move all things into manifest.json
@thescientist13
Copy link
Member Author

@thescientist13 thescientist13 mentioned this issue Mar 9, 2024
39 tasks
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 9 - Standards and Conventions Jun 18, 2024
@thescientist13 thescientist13 linked a pull request Jun 22, 2024 that will close this issue
39 tasks
@thescientist13 thescientist13 unpinned this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.3 breaking RFC Proposal and changes to workflows, architecture, APIs, etc v0.30.0
Projects
No open projects
1 participant