Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add no wrapping entry tag option for renderToString #115

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Mar 23, 2023

Related Issue

resolves #114

Summary of Changes

  1. Add support for a an option to enable / disable the presence of a wrapping tag for entry files to renderToString

TODO

  1. how to best handle metadata and entry point flag - refactor how definitions and entry points are determined (leverage default export) #117
  2. Documentation

@thescientist13 thescientist13 added documentation Improvements or additions to documentation feature New feature or request labels Mar 23, 2023
@thescientist13 thescientist13 changed the title add feature support for no wrapping entry tag option for renderToString add no wrapping entry tag option for renderToString Mar 23, 2023
@thescientist13 thescientist13 force-pushed the feature/issue-114-no-top-level-entry-point-wrapping-tag branch from 5f8d822 to d1353dd Compare April 1, 2023 18:26
@thescientist13 thescientist13 merged commit d973b8c into master Apr 1, 2023
@thescientist13 thescientist13 deleted the feature/issue-114-no-top-level-entry-point-wrapping-tag branch April 1, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opt out of top level wrapping entry tag name when using renderToString
1 participant