-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 87 jsx coarse grained observability #94
Merged
thescientist13
merged 13 commits into
master
from
feature/issue-87-jsx-automatic-observability
Jan 4, 2023
Merged
Feature/issue 87 jsx coarse grained observability #94
thescientist13
merged 13 commits into
master
from
feature/issue-87-jsx-automatic-observability
Jan 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
force-pushed
the
feature/issue-87-jsx-automatic-observability
branch
from
December 28, 2022 21:11
14941f4
to
9587335
Compare
thescientist13
changed the title
Feature/issue 87 jsx automatic observability
Feature/issue 87 jsx coarse grained observability
Dec 30, 2022
thescientist13
force-pushed
the
feature/issue-87-jsx-automatic-observability
branch
from
December 30, 2022 17:52
9587335
to
14bfdc2
Compare
thescientist13
force-pushed
the
feature/issue-87-jsx-automatic-observability
branch
from
December 30, 2022 22:52
14bfdc2
to
3fd435f
Compare
thescientist13
deleted the
feature/issue-87-jsx-automatic-observability
branch
January 4, 2023 20:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #87
Summary of Changes
render
andconstructor
functions for usages ofthis
to generateobservedAttributes
andattributeChangedCallback
export const inferredObservability = {boolean}
For example, this
Would produce this
Use it as
Very simple implementation right now mostly as a nice way to do basic text updates / substations, as can be seen in thescientist13/greenwood-counter-jsx#3
TODOs
attributeChangedCallback
with fine grained observabilityexport
to opt-in / outthis
state - all being tracked in Literalthis
Evaluation and Derivative References #88inferObservability
)Questions / Observations (follow up issues / discussions)
render
function up front before we parse and / or add instruction sets? - yes, I think we do this nowrender
andconstructor
? Or just infer fromrender()
only? - Will just userender
function for nowobservedAttributes
orattributeChangedCallback
exists, and merge? Or defer to what already exists? Explicit Opt-in / out?