Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph service should replace PROVIDER_BASE_URL with WEBHOOK_BASE_URL #356

Closed
2 tasks
mattheworris opened this issue Aug 9, 2024 · 0 comments
Closed
2 tasks

graph service should replace PROVIDER_BASE_URL with WEBHOOK_BASE_URL #356

mattheworris opened this issue Aug 9, 2024 · 0 comments
Assignees
@mattheworris
Labels
graph-service V1 Issues to be completed prior to releasing V1

Comments

@mattheworris
Copy link
Contributor

mattheworris commented Aug 9, 2024 •
edited
Loading

Description

The gateway microservices that use webhooks previously used the environment variable PROVIDER_BASE_URL as the webhook target server. The social-app-template has adopted a new nomenclature using WEBHOOK_BASE_URL. All micro services should be in sync with the social-app-template and use the new nomenclature.

Acceptance Criteria

  • All microservices that use webhooks use WEBHOOK_BASE_URL to provision their webhook.

    • graph service

Follow up to remove entirely: #339
@mattheworris mattheworris mentioned this issue Aug 9, 2024
Closed
4 tasks
@mattheworris mattheworris changed the title graph graph service should replace PROVIDER_BASE_URL with WEBHOOK_BASE_URL Aug 9, 2024
@mattheworris mattheworris self-assigned this Aug 9, 2024
@mattheworris mattheworris added graph-service V1 Issues to be completed prior to releasing V1 labels Aug 9, 2024
@mattheworris mattheworris linked a pull request Aug 9, 2024 that will close this issue
graph service should replace PROVIDER_BASE_URL with WEBHOOK_BASE_URL #357
Closed
2 tasks
@mattheworris mattheworris closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattheworris mattheworris

Labels
graph-service V1 Issues to be completed prior to releasing V1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

graph service should replace PROVIDER_BASE_URL with WEBHOOK_BASE_URL ProjectLibertyLabs/gateway
1 participant
@mattheworris