Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen PluginComponents PropType requirement for WindowTopBarPluginMenu #4096

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

marlo-longley
Copy link
Member

@marlo-longley marlo-longley commented Feb 6, 2025

This removes an error scary warning found in testing plugin integration in M4 (specifically as part of sul-dlss/sul-embed#2333)

Screenshot 2025-02-06 at 12 27 02 PM

This aligns this PropType with other components: for example see

PluginComponents: PropTypes.array, // eslint-disable-line react/forbid-prop-types

@marlo-longley marlo-longley force-pushed the plugin-component-proptype branch from 6239946 to b402e2f Compare February 6, 2025 17:30
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (6e15d9f) to head (b402e2f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4096      +/-   ##
==========================================
- Coverage   95.05%   95.05%   -0.01%     
==========================================
  Files         315      315              
  Lines       15906    15904       -2     
  Branches     2494     2494              
==========================================
- Hits        15120    15117       -3     
- Misses        782      783       +1     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marlo-longley marlo-longley marked this pull request as ready for review February 6, 2025 17:35
@cbeer cbeer merged commit e9f2bde into main Feb 10, 2025
8 of 9 checks passed
@cbeer cbeer deleted the plugin-component-proptype branch February 10, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants