-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve portal landing page and About content #215
Conversation
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 95e760d |
To do:
|
Pinging @kmpaul, I have some questions about the Pythia Sphinx theme. If you take a look at the preview for this PR, you'll see that I have some new text for what I'm calling the "Landing" section, i.e. the topmost section of the main page that uses the "Temple" background image. The text is shorter and snappier! And also includes some links. This raises two related issues:
I'm not sure if these require changes to the theme, or if I can customize in this repo. Any guidance? |
All of these can be changed with custom CSS (see the |
Ok, that's encouraging! I'll need a bit more guidance since I know nothing about CSS. Is there a simple way to specify formatting so that is applies just to that landing section of the page? |
@brian-rose: So, here's what you probably want to add to the main.banner-main #project-pythia {
padding-top: 6rem;
padding-bottom: 6rem;
}
main.banner-main #project-pythia p {
font-size: 1.6rem; /* default: 1.25rem */
/* font-weight: 700; default: 300 */
} Both of these specifications will apply to only the Feel free to tweak the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian-rose: Here are some suggestions. They aren't necessary, but I think it is a little cleaner. Your choice. I'm rather opinionated, so take this with a grain of salt.
@brian-rose: I love the section about "Why the name Pythia?" |
Co-authored-by: Kevin Paul <[email protected]>
Great! Thanks, I was out of my element with the CSS and I appreciate the suggestions. I think your version will get us closer to what I had in mind originally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was an error in my previous suggestions. This fixes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link needs fixing. The trailing slash breaks the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to fix headerlink hover color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! Fixed!
@brian-rose: Okay. I'm done futzing. I tweaked it and I think I fixed everything I messed up. 😄 |
What if we changed the subheading to read: "A community education and training hub for Pangeo" And then at the bottom of the section, instead of just a button taking you to the About section, also add a button taking you to Pangeo.io? |
I like that. I can mock that up right now so we can possibly discuss at the IWG meeting today. (although it's more "content" than "infrastructure") |
As mentioned at today's IWG meeting, please leave comments here about both the text and the styling! One issue with the current wording, "An education and training hub for the Pangeo community", is that it may seem too exclusive for visitors that aren't already familiar with Pangeo. |
@brian-rose: Yes. You're right about the specificity. Maybe that subheading should change, again. What about: "An education and training hub for the geoscientific Python & Pangeo community" Or maybe just: "An education and training hub for the geoscientific Python community" and then a subsubheading saying "A subsidiary of Pangeo" 😄 |
Now that I've thought of it a bit more, I actually wonder if the subheading should not change from what it currently is (i.e., "An education and training hub for the Pangeo community") and then just add a single, short sentence about Pangeo in the paragraph below. Something like "Pangeo is a community of practice to support geoscientists in open source and open science, notably around Python." |
@kmpaul I appreciate your thoughts here! I initially brought up concern about the wording at the meeting, and my preference is to combine both of your comments:
I'm struggling with specific wording at this very moment, but wanted to get my thoughts out here sooner rather than later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@brian-rose: There are 2 options for fixing the alignment in the buttons. The easiest option is to set The second option is more of an opinionated stylistic choice. Why have the If you have a preference of which one of these options you prefer, I can make a review with these suggestions, and then you can implement them with a click. But I feel like suggesting 2 different options in a single review is confusing. |
Thanks @kmpaul. I tried out both, and decided I prefer the words "About" to appear in the buttons. We can debate that at today's EWG meeting. |
@brian-rose: Sounds good. If you want to keep the "About" text in the button, then I think it looks a little better to match the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggestions for how to match the "About" text to the appearance of the image text, as well as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change adds the Pangeo "about" link.
Co-authored-by: Kevin Paul <[email protected]>
Ok I think I'm done tinkering! Personally I really like the look of the button now. Thanks again @kmpaul for all the formatting help. I have added a table of links to Pythia presentations at the bottom of the About page to this PR. Ready (again) for reviews now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian-rose: This is awesome! Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
Thanks all! With two approvals, I'm going to merge now. Maybe we can revisit the debates about wording and branding the next time we refresh the main page. |
Addresses #116
Also addresses #214 by explicitly mentioning Pangeo in the the landing section.