Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update-resource-gallery.yaml #392

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

erogluorhan
Copy link
Member

In an attempt to correct the fact that json file data is being dumped into yaml file with incorrect format

Correct the fact that json file data being dumped into yaml file with incorrect format
@erogluorhan erogluorhan requested a review from dcamron January 18, 2024 19:10
@erogluorhan erogluorhan requested a review from a team as a code owner January 18, 2024 19:10
@erogluorhan erogluorhan requested review from jukent and removed request for a team January 18, 2024 19:10
Copy link
Contributor

github-actions bot commented Jan 18, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: c81a92b
✅ Deployment Preview URL: In Progress

@erogluorhan
Copy link
Member Author

erogluorhan commented Jan 18, 2024

@dcamron, to hopefully fix the issue in PR #385

jukent
jukent previously approved these changes Jan 18, 2024
Copy link
Contributor

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix to me!

@jukent
Copy link
Contributor

jukent commented Jan 18, 2024

Environment solving issue breaking the site build seems important, but unrelated to this PR

@erogluorhan
Copy link
Member Author

Yes, I think it is a similar issue to what we had with cookbook-actions a few days ago. Currently looking into it.

@erogluorhan erogluorhan merged commit 65ca394 into main Jan 18, 2024
1 of 2 checks passed
@erogluorhan erogluorhan deleted the update-resource-gallery branch March 28, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants