-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduction update #460
base: main
Are you sure you want to change the base?
introduction update #460
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
I have left the comments Have a nice day! |
Thanks for this @serynabatov! I just added a couple edits. |
Hi @jukent ! I haven't found any comments unfortunately |
Oops! Good catch. |
@jukent What I mean - should I apply them locally and then update the PR or I can just say to Github "Ok, commit" and you will receive 5 different commits in this branch right now (The second one won't be a problem though if Pythia squashes the commits) |
I usually do the 2nd option but it's up to you! |
Co-authored-by: Julia Kent <[email protected]>
Co-authored-by: Julia Kent <[email protected]>
Co-authored-by: Julia Kent <[email protected]>
Ok, I've applied the comments |
@@ -54,6 +54,35 @@ | |||
"print(\"Hello interweb\")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is a nice addition! Here's my suggested language tweak of the first paragraph:
Variables are containers for storing data, whether simple or complex. They can represent primitive data types or point to other more sophisticated containers, e.g., lists and dicts (which we will introduce later in this notebook).
Reply via ReviewNB
@@ -453,159 +482,6 @@ | |||
" print(\"The value is:\", mypet[key])" | |||
] | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the argument for removing the numpy and matplotlib sections here?
This notebook is meant to be a "quick tour" of Python usage particularly for people who are arriving from other programming languages. These sections are meant to introduce the modularity of the Python language and the idea of importing specialized packages. They also give a brief flavor of two of the most fundamental packages for scientific python.
What about keeping these sections, but just adding a note to help guide beginners?
Hi!
I'm a collegue of https://github.com/himahuja. Unfortunatelly I won't be able to participate at the call
But he has told me everything.
I will going to provide my reasoning of why I have changed these lines of description.
Plus further I'll create a few different PRs (for the easier review purposes)