Skip to content

✨ [Effect 29, 30, 34] 継続ダメージ・回復エフェクトの実装 #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 20, 2025

Conversation

haiiro2gou
Copy link
Member

@haiiro2gou haiiro2gou commented Jan 29, 2025

Fix #846
Fix #724
Fix #725
Fix #820
Related #1064

Blocked by ProjectTSB/TheSkyBlessing#1840

@haiiro2gou haiiro2gou changed the title ✨ [Effect 29-30] 毒とウィザーを体力依存ダメージに ✨ [Effect 29-30 34] 継続ダメージ・回復エフェクトの実装 Mar 6, 2025
@haiiro2gou haiiro2gou changed the title ✨ [Effect 29-30 34] 継続ダメージ・回復エフェクトの実装 ✨ [Effect 29-30, 34] 継続ダメージ・回復エフェクトの実装 Mar 6, 2025
@haiiro2gou haiiro2gou linked an issue Mar 6, 2025 that may be closed by this pull request
@haiiro2gou haiiro2gou requested a review from Lapis-LJA March 8, 2025 19:08
Copy link
Contributor

@Lapis-LJA Lapis-LJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q.Effect34を継承した再生が全て割合になるのは意図している?
バランスに直結する問題なので少しどうかと思う

@haiiro2gou
Copy link
Member Author

Q.Effect34を継承した再生が全て割合になるのは意図している? バランスに直結する問題なので少しどうかと思う

毒 / ウィザーと揃えている

@ChenCMD
Copy link
Member

ChenCMD commented Mar 9, 2025

Q.Effect34を継承した再生が全て割合になるのは意図している? バランスに直結する問題なので少しどうかと思う

毒 / ウィザーと揃えている

これはバランス壊れるので NG です

@haiiro2gou haiiro2gou force-pushed the dev/haiiro_dot-effect branch from a746623 to cf295b7 Compare March 9, 2025 04:22
@haiiro2gou haiiro2gou requested review from Lapis-LJA and ChenCMD March 9, 2025 05:57
@haiiro2gou haiiro2gou changed the title ✨ [Effect 29-30, 34] 継続ダメージ・回復エフェクトの実装 ✨ [Effect 29, 30, 34] 継続ダメージ・回復エフェクトの実装 Mar 10, 2025
@haiiro2gou haiiro2gou requested a review from Lapis-LJA March 20, 2025 13:36
@haiiro2gou haiiro2gou merged commit a4b86d1 into master Mar 20, 2025
2 checks passed
@haiiro2gou haiiro2gou deleted the dev/haiiro_dot-effect branch March 20, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants