-
Notifications
You must be signed in to change notification settings - Fork 1
✨ [Effect 29, 30, 34] 継続ダメージ・回復エフェクトの実装 #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lapis-LJA
reviewed
Mar 6, 2025
Asset/data/asset/functions/effect/0029.poison/register.mcfunction
Outdated
Show resolved
Hide resolved
Lapis-LJA
reviewed
Mar 8, 2025
Lapis-LJA
requested changes
Mar 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q.Effect34を継承した再生が全て割合になるのは意図している?
バランスに直結する問題なので少しどうかと思う
Asset/data/asset/functions/effect/0266.grace_of_the_earth/register.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/effect/0301.soul_light/re-given/.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/artifact/0012.sketchy_herb/trigger/3.main.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/artifact/1057.great_demon_head/trigger/tick/heal.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/effect/0029.poison/tick/deal_damage.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/effect/0205.convallatoxin/tick/deal_damage.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/effect/0270.honey_regeneration/tick/heal.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/effect/0279.poison_of_vinderre/tick/deal_damage.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/effect/0301.soul_light/tick/heal.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/mob/0058.divide_haze/tick/.mcfunction
Outdated
Show resolved
Hide resolved
毒 / ウィザーと揃えている |
これはバランス壊れるので NG です |
a746623
to
cf295b7
Compare
Lapis-LJA
requested changes
Mar 20, 2025
Asset/data/asset/functions/mob/0220.vena_cana/hurt/clear_regen.mcfunction
Outdated
Show resolved
Hide resolved
Asset/data/asset/functions/effect/0266.grace_of_the_earth/register.mcfunction
Outdated
Show resolved
Hide resolved
Lapis-LJA
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #846
Fix #724
Fix #725
Fix #820
Related #1064
Blocked by ProjectTSB/TheSkyBlessing#1840